[Merged by Bors] - feat(linear_algebra/free_module/finite/rank): remove module.free assumption
#18792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
github-actions
bot
added
the
modifies-synchronized-file
eric-wieser
requested review from
riccardobrasca
and removed request for
riccardobrasca
|
The linter is complaining (and we're happy about it!), but otherwise LGTM. bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
github-actions
bot
removed
the
awaiting-CI
|
bors merge |
github-actions
bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
module.free assumptionmodule.free assumption
Parcly-Taxel
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 12, 2023
eric-wieser
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 13, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 13, 2023
* `set_theory.cardinal.basic`: forward-ports leanprover-community/mathlib#18781, which backports some ad-hoc changes in #3247 in a more principled way * `ring_theory.int.basic`: these changes were already forward-ported in #3278, but we forgot the SHA. * `linear_algebra.dimension`: forward-ports leanprover-community/mathlib#18792 * `linear_algebra.matrix.dot_product`: forward-ports leanprover-community/mathlib#18783 * `linear_algebra.finrank`: forward-ports leanprover-community/mathlib#18794 which is itself a backport of #3378, hence no changes to the file Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with the result in #18787, this lets us golf a downstream proof about matrices.