Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/matrix/reflection): add mul_vec and vec_mul #18805

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Apr 13, 2023

This follows the pattern already established by mul.

The motivation was an example on Zulip which wanted to compute the product of

def M := !![(2:ℂ), 0, 0; 0, 1, 0; 0, 0, 1]
def v := ![(0:ℂ), 0, 1]

As before, the meta code that makes this pleasant to use is absent, but I will add it along with the rest of the meta code in #15738.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Apr 13, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 13, 2023
@ocfnash
Copy link
Collaborator

ocfnash commented Apr 13, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 13, 2023
bors bot pushed a commit that referenced this pull request Apr 13, 2023
This follows the pattern already established by `mul`.

The motivation was an example on Zulip which wanted to compute the product of
```lean
def M := !![(2:ℂ), 0, 0; 0, 1, 0; 0, 0, 1]
def v := ![(0:ℂ), 0, 1]
```

As before, the meta code that makes this pleasant to use is absent, but I will add it along with the rest of the meta code in #15738.
@bors
Copy link

bors bot commented Apr 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/matrix/reflection): add mul_vec and vec_mul [Merged by Bors] - feat(data/matrix/reflection): add mul_vec and vec_mul Apr 13, 2023
@bors bors bot closed this Apr 13, 2023
@bors bors bot deleted the eric-wieser/reflection-mul_vec branch April 13, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants