Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/module/submodule/basic): add has_vadd #18815

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(algebra/module/submodule/basic): add has_vadd #18815

wants to merge 3 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Apr 16, 2023

Open in Gitpod

@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Apr 16, 2023
@xroblot xroblot added awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) and removed modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. labels Apr 16, 2023
@xroblot xroblot mentioned this pull request Apr 16, 2023
Closed
3 tasks
@xroblot xroblot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Apr 16, 2023
eric-wieser
eric-wieser approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Is there a reason you've marked this as draft?

@bors
Copy link

bors bot commented Apr 16, 2023

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the delegated The PR author may merge after reviewing final suggestions. label Apr 16, 2023
@xroblot
Copy link
Collaborator Author

xroblot commented Apr 16, 2023

bors d+

Is there a reason you've marked this as draft?

Well, I was waiting for it to pass CI first...

@xroblot @eric-wieser
Update src/algebra/module/submodule/basic.lean
120eacf 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@xroblot xroblot marked this pull request as ready for review April 16, 2023 14:24
@eric-wieser
Copy link
Member

bors merge

@bors
Copy link

bors bot commented Apr 17, 2023

👎 Rejected by label

@eric-wieser eric-wieser removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 17, 2023
@eric-wieser
Copy link
Member

bors merge

(CI failure is fixed in master)

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Apr 17, 2023
bors bot pushed a commit that referenced this pull request Apr 17, 2023
@xroblot
feat(algebra/module/submodule/basic): add has_vadd (#18815)
155d551
@bors
Copy link

bors bot commented Apr 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/module/submodule/basic): add has_vadd [Merged by Bors] - feat(algebra/module/submodule/basic): add has_vadd Apr 17, 2023
@bors bors bot closed this Apr 17, 2023
@bors bors bot deleted the xfr-action_submodule branch April 17, 2023 14:15
@eric-wieser eric-wieser mentioned this pull request Apr 18, 2023
Closed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 18, 2023
@Parcly-Taxel
chore: forward port leanprover-community/mathlib#18815 and part of le…
e724faf 
…anprover-community/mathlib#18248 (#3496)
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 10, 2023
@Parcly-Taxel
chore: forward port leanprover-community/mathlib#18815 and part of le…
59b7878 
…anprover-community/mathlib#18248 (#3496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xroblot @eric-wieser @leanprover-community-bot-assistant