New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(group_theory): simple lemmas for Wedderburn #18862
Conversation
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@@ -192,6 +192,8 @@ local attribute [instance] orbit_rel | |||
|
|||
variables {α} {β} | |||
|
|||
lemma orbit_rel_rel_iff {x y : β} : (orbit_rel α β).rel x y ↔ x ∈ orbit α y := iff.rfl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and yes, this new name is pretty terrible - suggestions welcome too here Yael
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orbit_rel_apply
? But to make this name work we would need setoid α
to be fun_like
. Why isn't it already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a refactor that should be done in lean3 :b I'll stick with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fair, you don't to refactor anything to add the instance. And you can make a simp lemma coe_eq_rel : ⇑s = s.rel
to avoid needing to translate the API.
src/group_theory/subgroup/basic.lean
Outdated
@@ -2670,6 +2670,16 @@ begin | |||
exact subset_normal_closure (set.mem_singleton _), | |||
end | |||
|
|||
variables (G) {M : Type*} [monoid M] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need (G)
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. Thanks!
bors d+
✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
These lemmas are a bit disparate, but they are all useful for Wedderburn's little theorem. Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
These lemmas are a bit disparate, but they are all useful for Wedderburn's little theorem.