Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory): simple lemmas for Wedderburn #18862

Closed
wants to merge 12 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Apr 24, 2023

These lemmas are a bit disparate, but they are all useful for Wedderburn's little theorem.


Open in Gitpod

@ericrbg ericrbg added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-algebra Algebra (groups, rings, fields etc) labels Apr 24, 2023
@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Apr 24, 2023
src/group_theory/subgroup/basic.lean Outdated Show resolved Hide resolved
src/group_theory/subgroup/basic.lean Outdated Show resolved Hide resolved
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@@ -192,6 +192,8 @@ local attribute [instance] orbit_rel

variables {α} {β}

lemma orbit_rel_rel_iff {x y : β} : (orbit_rel α β).rel x y ↔ x ∈ orbit α y := iff.rfl
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and yes, this new name is pretty terrible - suggestions welcome too here Yael

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orbit_rel_apply? But to make this name work we would need setoid α to be fun_like. Why isn't it already?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a refactor that should be done in lean3 :b I'll stick with that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, you don't to refactor anything to add the instance. And you can make a simp lemma coe_eq_rel : ⇑s = s.rel to avoid needing to translate the API.

@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Apr 24, 2023
This reverts commit 948ef18.
This reverts commit 201ece8.
@@ -2670,6 +2670,16 @@ begin
exact subset_normal_closure (set.mem_singleton _),
end

variables (G) {M : Type*} [monoid M]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need (G) here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks!
bors d+

@bors
Copy link

bors bot commented Jun 21, 2023

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ericrbg
Copy link
Collaborator Author

ericrbg commented Jun 22, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jun 22, 2023
These lemmas are a bit disparate, but they are all useful for Wedderburn's little theorem.



Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Jun 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(group_theory): simple lemmas for Wedderburn [Merged by Bors] - feat(group_theory): simple lemmas for Wedderburn Jun 22, 2023
@bors bors bot closed this Jun 22, 2023
@bors bors bot deleted the ericrbg/wedderburn-lemmas branch June 22, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review The author would like community review of the PR modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants