Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(probability/kernel/composition): swap the order of the arguments of prod_mk_left #18929

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(probability/kernel/composition): swap the order of the arguments of prod_mk_left #18929

wants to merge 1 commit into from

Conversation

RemyDegenne
Copy link
Collaborator

Since prod_mk_left γ κ creates a kernel (γ × α) β from κ : kernel α β, it makes more sense to put the γ argument to the left.

Open in Gitpod

@RemyDegenne RemyDegenne added awaiting-review The author would like community review of the PR t-measure-probability Measure theory / Probability theory labels May 3, 2023
@RemyDegenne RemyDegenne requested a review from a team as a code owner May 3, 2023 05:56
jcommelin
jcommelin approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 4, 2023
bors bot pushed a commit that referenced this pull request May 4, 2023
@RemyDegenne
chore(probability/kernel/composition): swap the order of the argument…
698c80e 
…s of prod_mk_left (#18929)

Since `prod_mk_left γ κ` creates a `kernel (γ × α) β` from `κ : kernel α β`, it makes more sense to put the `γ` argument to the left.
@bors
Copy link

bors bot commented May 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(probability/kernel/composition): swap the order of the arguments of prod_mk_left [Merged by Bors] - chore(probability/kernel/composition): swap the order of the arguments of prod_mk_left May 4, 2023
@bors bors bot closed this May 4, 2023
@bors bors bot deleted the RD_prod_mk_left branch May 4, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-measure-probability Measure theory / Probability theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RemyDegenne @jcommelin @leanprover-community-bot-assistant