Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/category): Free functor Lat ⥤ BddLat #18949

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(order/category): Free functor Lat ⥤ BddLat #18949

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Construct the free functor from the category of lattices to the category of bounded lattices. Concretely, it adds a bottom and a top element.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. t-order Order hierarchy t-category-theory Category theory modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. labels May 5, 2023
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 5, 2023
jcommelin
jcommelin approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems the the out-of-sync was at capacity, hence:

bors d+

@bors
Copy link

bors bot commented May 6, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels May 6, 2023
@YaelDillies
Copy link
Collaborator Author

Now at 18/20

@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request May 6, 2023
@YaelDillies @eric-wieser
feat(order/category): Free functor Lat ⥤ BddLat (#18949)
7581030 
Construct the free functor from the category of lattices to the category of bounded lattices. Concretely, it adds a bottom and a top element.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented May 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(order/category): Free functor Lat ⥤ BddLat [Merged by Bors] - feat(order/category): Free functor Lat ⥤ BddLat May 7, 2023
@bors bors bot closed this May 7, 2023
@bors bors bot deleted the Lat_to_BddLat branch May 7, 2023 00:35
YaelDillies added a commit to leanprover-community/mathlib4 that referenced this pull request May 11, 2023
@YaelDillies
feat: Free functor Lat ⥤ BddLat
19a99d0 
Match leanprover-community/mathlib#18949

[`order.hom.lattice`@`9d684a893c52e1d6692a504a118bfccbae04feeb`..`7581030920af3dcb241d1df0e36f6ec8289dd6be`](https://leanprover-community.github.io/mathlib-port-status/file/order/hom/lattice?range=9d684a893c52e1d6692a504a118bfccbae04feeb..7581030920af3dcb241d1df0e36f6ec8289dd6be)
@YaelDillies YaelDillies mentioned this pull request May 11, 2023
Closed
joneugster pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 13, 2023
@YaelDillies @joneugster
feat: Free functor Lat ⥤ BddLat
17496c2 
Match leanprover-community/mathlib#18949

[`order.hom.lattice`@`9d684a893c52e1d6692a504a118bfccbae04feeb`..`7581030920af3dcb241d1df0e36f6ec8289dd6be`](https://leanprover-community.github.io/mathlib-port-status/file/order/hom/lattice?range=9d684a893c52e1d6692a504a118bfccbae04feeb..7581030920af3dcb241d1df0e36f6ec8289dd6be)
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 14, 2023
@YaelDillies @joneugster
chore: forward-port leanprover-community/mathlib#18949 (#3918)
b1701f8 
Match leanprover-community/mathlib#18949

[`order.hom.lattice`@`9d684a893c52e1d6692a504a118bfccbae04feeb`..`7581030920af3dcb241d1df0e36f6ec8289dd6be`](https://leanprover-community.github.io/mathlib-port-status/file/order/hom/lattice?range=9d684a893c52e1d6692a504a118bfccbae04feeb..7581030920af3dcb241d1df0e36f6ec8289dd6be)




Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
alexkeizer pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 22, 2023
@YaelDillies @joneugster @alexkeizer
chore: forward-port leanprover-community/mathlib#18949 (#3918)
a5b47ae 
Match leanprover-community/mathlib#18949

[`order.hom.lattice`@`9d684a893c52e1d6692a504a118bfccbae04feeb`..`7581030920af3dcb241d1df0e36f6ec8289dd6be`](https://leanprover-community.github.io/mathlib-port-status/file/order/hom/lattice?range=9d684a893c52e1d6692a504a118bfccbae04feeb..7581030920af3dcb241d1df0e36f6ec8289dd6be)




Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 25, 2023
@YaelDillies @joneugster @semorrison
chore: forward-port leanprover-community/mathlib#18949 (#3918)
7f243c3 
Match leanprover-community/mathlib#18949

[`order.hom.lattice`@`9d684a893c52e1d6692a504a118bfccbae04feeb`..`7581030920af3dcb241d1df0e36f6ec8289dd6be`](https://leanprover-community.github.io/mathlib-port-status/file/order/hom/lattice?range=9d684a893c52e1d6692a504a118bfccbae04feeb..7581030920af3dcb241d1df0e36f6ec8289dd6be)




Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. t-category-theory Category theory t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YaelDillies @jcommelin @leanprover-community-bot-assistant @mathlib-dependent-issues-bot @eric-wieser