[Merged by Bors] - fix(group_theory/subgroup/basic): generalize centralizer from subgroup G to set G
#18965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t G` This is consistent with all the other `sub<foo>.centralizer` definitions.
eric-wieser
added
awaiting-review
github-actions
bot
added
the
modifies-synchronized-file
eric-wieser
changed the title
subgroup G to set Gcentralizer from subgroup G to set G
github-actions
bot
removed
the
awaiting-CI
|
are you still planning on going forward with this? happy to solve the merge conflicts |
…group-centralizer
|
I've fixed the conflicts |
eric-wieser
commented
Jun 19, 2023
eric-wieser
added
the
not-too-late
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
…roup G` to `set G` (#18965) This is consistent with all the other `sub<foo>.centralizer` definitions. This generalization reveals that a lot of downstream results are rather strangely stated about `zpowers`. This does not attempt to change these, instead leaving the work for a follow up (either in a later mathlib3 PR or in mathlib4).
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
centralizer from subgroup G to set Gcentralizer from subgroup G to set G
eric-wieser
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 26, 2023
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 27, 2023
semorrison
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with all the other
sub<foo>.centralizerdefinitions.This generalization reveals that a lot of downstream results are rather strangely stated about
zpowers.This does not attempt to change these, instead leaving the work for a follow up (either in a later mathlib3 PR or in mathlib4).
This has been complained about twice now, so seemed worth fixing.