Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(analysis/convex/specific_functions): split #19031

Closed
wants to merge 17 commits into from

Conversation

hrmacbeth
Copy link
Member

Split analysis/convex/specific_function into a part which doesn't require differentiation (as of #19026) and a part which does. This removes the dependence of measure_theory/integral/bochner on differentiation, and decreases by 11 the length of the longest path in mathlib.

See Zulip


Open in Gitpod

@hrmacbeth hrmacbeth requested a review from a team as a code owner May 18, 2023 00:16
@hrmacbeth hrmacbeth added the awaiting-CI The author would like to see what CI has to say before doing more work. label May 18, 2023
@semorrison
Copy link
Collaborator

bors d+

@bors
Copy link

bors bot commented May 18, 2023

✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels May 18, 2023
@hrmacbeth
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 18, 2023
bors bot pushed a commit that referenced this pull request May 18, 2023
Split `analysis/convex/specific_function` into a part which doesn't require differentiation (as of #19026) and a part which does.  This removes the dependence of `measure_theory/integral/bochner` on differentiation, and decreases by 11 the length of the longest path in mathlib.

See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Shortcut.20to.20integration)
@bors
Copy link

bors bot commented May 18, 2023

Build failed:

@hrmacbeth
Copy link
Member Author

hrmacbeth commented May 18, 2023

Timeout on this def (measure_theory.Lp.simple_func.normed_space), I don't understand why since it passed CI before:

/-- If `E` is a normed space, `Lp.simple_func E p μ` is a normed space. Not declared as an
instance as it is (as of writing) used only in the construction of the Bochner integral. -/
protected def normed_space [fact (1 ≤ p)] : normed_space 𝕜 (Lp.simple_func E p μ) :=
⟨ λc f, by { rw [add_subgroup.coe_norm, add_subgroup.coe_norm, coe_smul, norm_smul] } ⟩

@hrmacbeth
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request May 18, 2023
Split `analysis/convex/specific_function` into a part which doesn't require differentiation (as of #19026) and a part which does.  This removes the dependence of `measure_theory/integral/bochner` on differentiation, and decreases by 11 the length of the longest path in mathlib.

See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Shortcut.20to.20integration)



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor(analysis/convex/specific_functions): split [Merged by Bors] - refactor(analysis/convex/specific_functions): split May 18, 2023
@bors bors bot closed this May 18, 2023
@bors bors bot deleted the hrmacbeth-downgrade-convex-2 branch May 18, 2023 15:19
bors bot pushed a commit that referenced this pull request Jun 2, 2023
…mports (#19140)

I accidentally left some extra imports in this file during the split #19031.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants