Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/function/l1_space): generalize multiplicative results to is_unit #19073

Closed
wants to merge 17 commits into from
Closed

[Merged by Bors] - feat(measure_theory/function/l1_space): generalize multiplicative results to is_unit #19073

wants to merge 17 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 23, 2023 •
edited

This generalization lets us use these lemmas for left- and right- multiplication by non-commutative normed rings.

This doesn't make it all the way to integral_mul_const, but it's a step in that direction.

Open in Gitpod

@eric-wieser eric-wieser added the WIP Work in progress label May 23, 2023
@eric-wieser eric-wieser requested a review from a team as a code owner May 23, 2023 20:09
@eric-wieser eric-wieser changed the title chore(measure_theory/function/l1_space): golf downstream results chore(measure_theory/function/l1_space): generalize to is_unit May 23, 2023
@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label May 23, 2023
@eric-wieser eric-wieser changed the title chore(measure_theory/function/l1_space): generalize to is_unit chore(measure_theory/function/l1_space): generalize multiplicative results to is_unit May 23, 2023
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 24, 2023
@semorrison semorrison added the wait-requested-on #port-comments requests that a port waits on this PR. label May 24, 2023
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 24, 2023
@mathlib-dependent-issues-bot mathlib-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 24, 2023
@eric-wieser eric-wieser mentioned this pull request May 26, 2023
Closed
3 tasks
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed WIP Work in progress modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 26, 2023
@mathlib-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@eric-wieser eric-wieser changed the title chore(measure_theory/function/l1_space): generalize multiplicative results to is_unit refactor(measure_theory/function/l1_space): generalize multiplicative results to is_unit and smul results to normed_ring May 26, 2023
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 26, 2023
@eric-wieser eric-wieser requested a review from urkud May 26, 2023 18:40
@eric-wieser eric-wieser changed the title refactor(measure_theory/function/l1_space): generalize multiplicative results to is_unit and smul results to normed_ring feat(measure_theory/function/l1_space): generalize multiplicative results to is_unit May 27, 2023
@eric-wieser eric-wieser added the t-measure-probability Measure theory / Probability theory label May 27, 2023
@urkud
Copy link
Member

urkud commented May 27, 2023

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 27, 2023
bors bot pushed a commit that referenced this pull request May 27, 2023
@eric-wieser
feat(measure_theory/function/l1_space): generalize multiplicative res…
13b0d72 
…ults to is_unit (#19073)

This generalization lets us use these lemmas for left- and right- multiplication by non-commutative normed rings.

This doesn't make it all the way to `integral_mul_const`, but it's a step in that direction.
@bors
Copy link

bors bot commented May 27, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(measure_theory/function/l1_space): generalize multiplicative results to is_unit [Merged by Bors] - feat(measure_theory/function/l1_space): generalize multiplicative results to is_unit May 27, 2023
@bors bors bot closed this May 27, 2023
@bors bors bot deleted the eric-wieser/bounded-smul-cleanup branch May 27, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud Awaiting requested review from urkud

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-measure-probability Measure theory / Probability theory wait-requested-on #port-comments requests that a port waits on this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eric-wieser @mathlib-dependent-issues-bot @urkud @semorrison