Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(topology/algebra/module/basic): generalize to_span_singleton to topological spaces #19116

Closed
wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 28, 2023

This should be straightforward to forward-port, as it involves deleting one hunk and pasting in another.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. t-topology Topological spaces, uniform spaces, metric spaces, filters mathlib4-synchronization This PR *only* adds a message to the module doc about synchronization with mathlib4 labels May 28, 2023
@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label May 28, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label May 28, 2023
@eric-wieser eric-wieser removed the mathlib4-synchronization This PR *only* adds a message to the module doc about synchronization with mathlib4 label May 31, 2023
@urkud
Copy link
Member

urkud commented Jun 21, 2023

While you're at it, could you please add a version of span_singleton_eq_range using continuous_linear_map.to_span_singleton?

LGTM. Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 21, 2023
bors bot pushed a commit that referenced this pull request Jun 21, 2023
…to topological spaces (#19116)

This should be straightforward to forward-port, as it involves deleting one hunk and pasting in another.
@bors
Copy link

bors bot commented Jun 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(topology/algebra/module/basic): generalize to_span_singleton to topological spaces [Merged by Bors] - chore(topology/algebra/module/basic): generalize to_span_singleton to topological spaces Jun 21, 2023
@bors bors bot closed this Jun 21, 2023
@bors bors bot deleted the eric-wieser/to_span_singletonL branch June 21, 2023 22:24
eric-wieser added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 23, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 23, 2023
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jun 25, 2023
kbuzzard pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants