[Merged by Bors] - chore(archive + counterexamples): namespaces imo, theorems_100, counterexample, plus three more #19129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
changed the title
adomani
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 30, 2023
…erexample, plus three more (#19129) This PR is a revision of #19122: it addresses namespacing in `archive` and `counterexamples`. The main difference with #19122 is that it adds namespaces less aggressively: I added a namespace only if there was not an explicit namespace after the initial "fluff". In `counterexamples`, I added namespaces to all files. I introduced three "main" namespaces: `imo, theorems_100, counterexample` (the last one singular). Besides these, I also introduced the namespaces `prop_encodable, oxford_invariants, sensitivity`, to cover the left-over files in `archive`. Note that if a file has `namespace` early on, then it does not get a new namespace, even though it might be desirable for it to have one. Comments are very welcome! Note: besides adding namespaces, the only files that I had to manually edit are the ones in * commit d337b99 -- I do not like these changes, but currently do not see how to avoid them; * commit 48471f3 -- I *removed* an pre-existing namespace, replacing it by `open <itself>`. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/mk_all.2Esh): this PR is motivated by the desire to port to mathlib4 the files in `archive, counterexamples`, taking advantage of `mathport`. The namespacing helps with avoiding clashes among names of declarations, as well as one-lettered declarations in the root namespace.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a revision of #19122: it addresses namespacing in
archiveandcounterexamples.The main difference with #19122 is that it adds namespaces less aggressively: I added a namespace only if there was not an explicit namespace after the initial "fluff". In
counterexamples, I added namespaces to all files.I introduced three "main" namespaces:
imo, theorems_100, counterexample(the last one singular). Besides these, I also introduced the namespacesprop_encodable, oxford_invariants, sensitivity, to cover the left-over files inarchive.Note that if a file has
namespaceearly on, then it does not get a new namespace, even though it might be desirable for it to have one.Comments are very welcome!
Note: besides adding namespaces, the only files that I had to manually edit are the ones in
open <itself>.Zulip discussion: this PR is motivated by the desire to port to mathlib4 the files in
archive, counterexamples, taking advantage ofmathport. The namespacing helps with avoiding clashes among names of declarations, as well as one-lettered declarations in the root namespace.