Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(geometry/manifold/cont_mdiff_map): refactor to reduce imports #19164

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - refactor(geometry/manifold/cont_mdiff_map): refactor to reduce imports #19164

wants to merge 3 commits into from

Conversation

semorrison
Copy link
Collaborator

See https://tqft.net/mathlib4/2023-06-07/geometry.manifold.algebra.left_invariant_derivation.pdf for the motivation.

I'm happy if this one is shot down. :-)

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jun 7, 2023
@semorrison semorrison requested a review from hrmacbeth June 7, 2023 03:34
@hrmacbeth
Copy link
Member

I am on board with this, I actually made the same refactor as a test a couple of days ago!
https://github.com/leanprover-community/mathlib/compare/hrmacbeth-downgrade-cont_mdiff_map

I think that long term we might want to refactor to separate mdifferentiable and mfderiv into separate files, since the former is much more elementary. But the approach here is good enough for now.

@hrmacbeth
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Jun 7, 2023

👎 Rejected by label

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 7, 2023
@hrmacbeth
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jun 7, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Jun 7, 2023
@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 7, 2023
@semorrison
refactor(geometry/manifold/cont_mdiff_map): refactor to reduce imports (
0dc4079 
#19164)

See https://tqft.net/mathlib4/2023-06-07/geometry.manifold.algebra.left_invariant_derivation.pdf for the motivation.

I'm happy if this one is shot down. :-)



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor(geometry/manifold/cont_mdiff_map): refactor to reduce imports [Merged by Bors] - refactor(geometry/manifold/cont_mdiff_map): refactor to reduce imports Jun 7, 2023
@bors bors bot closed this Jun 7, 2023
@bors bors bot deleted the cont_mdiff_map branch June 7, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrmacbeth hrmacbeth Awaiting requested review from hrmacbeth

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @hrmacbeth