Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(tactic/interval_cases): instantiate metavars #19232

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix(tactic/interval_cases): instantiate metavars #19232

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

The test included in this commit fails without this change.

This does not need forward-porting, the test already passes in Lean 4.

Open in Gitpod

@eric-wieser
fix: instatiate metavars in interval_cases
85e6df6 
The test included in this commit fails without this change.

This does not need forward-porting, the test already passes in Lean 4.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 11, 2023
@eric-wieser eric-wieser requested a review from a team as a code owner July 11, 2023 21:57
@eric-wieser eric-wieser added the t-meta Tactics, attributes or user commands label Jul 11, 2023
@eric-wieser eric-wieser changed the title fix: instatiate metavars in interval_cases fix(tactic/interval_cases): instantiate metavars Jul 11, 2023
kmill
kmill approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@kmill kmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. In Lean 4 with Qq, the ~q(...) match expressions are up to defeq, so instantiateMVars isn't necessary there.

bors d+

(I'm more familiar with interval_cases internals than linarith, so I'm leaving your other PR for someone else to give another review.)

@bors
Copy link

bors bot commented Jul 11, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 11, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jul 11, 2023
@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 12, 2023
bors bot pushed a commit that referenced this pull request Jul 12, 2023
@eric-wieser
fix(tactic/interval_cases): instantiate metavars (#19232)
2932d9e 
The test included in this commit fails without this change.

This does not need forward-porting, the test already passes in Lean 4.
@bors
Copy link

bors bot commented Jul 12, 2023

Build failed:

@eric-wieser
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 12, 2023
@eric-wieser
fix(tactic/interval_cases): instantiate metavars (#19232)
d3b54a9 
The test included in this commit fails without this change.

This does not need forward-porting, the test already passes in Lean 4.
@bors
Copy link

bors bot commented Jul 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix(tactic/interval_cases): instantiate metavars [Merged by Bors] - fix(tactic/interval_cases): instantiate metavars Jul 12, 2023
@bors bors bot closed this Jul 12, 2023
@bors bors bot deleted the eric-wieser/interval_cases-mvars-fix branch July 12, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @kmill @leanprover-community-bot-assistant