Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: handle archive and counterexamples correctly when adding port comments #19237

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jul 15, 2023


Open in Gitpod

I tested this as https://github.com/leanprover-community/mathlib/actions/runs/5562830214 and it produced #19238 which looks correct.

I think it's clear this is not affected by the freeze.

@eric-wieser eric-wieser added CI This issue or PR is about continuous integration awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 15, 2023
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Jul 15, 2023
@semorrison semorrison added the not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 label Jul 16, 2023
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 16, 2023
bors bot pushed a commit that referenced this pull request Jul 16, 2023
@bors
Copy link

bors bot commented Jul 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: handle archive and counterexamples correctly when adding port comments [Merged by Bors] - fix: handle archive and counterexamples correctly when adding port comments Jul 16, 2023
@bors bors bot closed this Jul 16, 2023
@bors bors bot deleted the fix-port-comments branch July 16, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI This issue or PR is about continuous integration not-too-late This PR was ready at the point mathlib3 was frozen: we will try to merge it and port it to mathlib4 ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants