feat(tactic/lint): check if inhabited instances should be nonempty #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gebner
reviewed
Feb 10, 2020
robertylewis
added
the
awaiting-review
|
Well, that's good to know: GH Actions does build a merge commit on PR builds. I was wondering if/how to avoid the duplicate PR and branch builds, but they're apparently not duplicates. |
robertylewis
force-pushed
the
nonempty_linter
branch
from
234877c
to
bbaf10a
Compare
fpvandoorn
approved these changes
Feb 10, 2020
fpvandoorn
removed
the
awaiting-review
|
Well, that was fast, I rebased it this afternoon. Will fix tomorrow. |
robertylewis
added
the
ready-to-merge
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…eanprover-community#1971) * add inhabited vs nonempty linter * add new linter to ci * start updating files to pass linter * more linter fixes * fix more linter errors * more fixes * fix build * remove unnecessary instances * nicer proof * adjust inhabit tactic * improve proof * move instance to better place * generalize instance * fix build * inhabited -> nonempty * fix build
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…eanprover-community#1971) * add inhabited vs nonempty linter * add new linter to ci * start updating files to pass linter * more linter fixes * fix more linter errors * more fixes * fix build * remove unnecessary instances * nicer proof * adjust inhabit tactic * improve proof * move instance to better place * generalize instance * fix build * inhabited -> nonempty * fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mentioned here and in #1924. In a theorem or lemma, an argument of type
inhabitedthat isn't used in following arguments or in the type can be (constructively) weakened tononempty.For convenience, this PR also adds a tactic
inhabit αthat upgrades anonempty αinstance in the local context toinhabited α.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list