Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analysis/normed_space/basic): implicit args #2011

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 18, 2020

Arguments to these iffs should be implicit.

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

Arguments to these `iff`s should be implicit.
@sgouezel sgouezel added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Feb 18, 2020
@mergify mergify bot merged commit 0c2dbd5 into master Feb 18, 2020
@mergify mergify bot deleted the norm-pos-iff branch February 18, 2020 17:07
@PatrickMassot
Copy link
Member

I wonder if we could have a linter detecting this: if a lemma is an iff or equality, then check that every variable that appears on both sides is implicit.

@robertylewis robertylewis mentioned this pull request Feb 18, 2020
7 tasks
@gebner
Copy link
Member

gebner commented Feb 18, 2020

@PatrickMassot I added your idea to our grand linter todo list #1924.

anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants