[Merged by Bors] - feat(algebra/big-operators): some big operator lemmas #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-mehta
added
the
awaiting-review
b-mehta
changed the title
sgouezel
reviewed
Mar 15, 2020
sgouezel
added
awaiting-author
jcommelin
reviewed
Mar 16, 2020
|
What is the status of this PR? The lemmas in there seem useful, and it looks like it only needs minor corrections to be merged. |
|
I think all the suggestions are addressed! |
b-mehta
added
awaiting-review
|
@b-mehta, there are several open conversations above, from sgouezel --- could you either reply saying you've fixed them, or reply and click resolve conversation (assuming no further discussion is required). It's much easier for other reviewers who come along to work out where everything is up to. |
jcommelin
reviewed
Apr 13, 2020
|
✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with |
semorrison
added
ready-to-merge
Co-Authored-By: Johan Commelin <johan@commelin.net>
|
bors r+ |
|
👎 Rejected by label |
sgouezel
added
ready-to-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2020
Lemmas I found useful in my [combinatorics](https://b-mehta.github.io/combinatorics/) project Make sure you have: * [x] reviewed and applied the coding style: [coding](https://github.com/leanprover/mathlib/blob/master/docs/contribute/style.md), [naming](https://github.com/leanprover/mathlib/blob/master/docs/contribute/naming.md) * [x] reviewed and applied [the documentation requirements](https://github.com/leanprover/mathlib/blob/master/docs/contribute/doc.md) * [x] make sure definitions and lemmas are put in the right files * [x] make sure definitions and lemmas are not redundant If this PR is related to a discussion on Zulip, please include a link in the discussion. For reviewers: [code review check list](https://github.com/leanprover/mathlib/blob/master/docs/contribute/code-review.md)
Build succeeded |
Pull request successfully merged into master. |
bors
bot
changed the title
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…munity#2152) Lemmas I found useful in my [combinatorics](https://b-mehta.github.io/combinatorics/) project Make sure you have: * [x] reviewed and applied the coding style: [coding](https://github.com/leanprover/mathlib/blob/master/docs/contribute/style.md), [naming](https://github.com/leanprover/mathlib/blob/master/docs/contribute/naming.md) * [x] reviewed and applied [the documentation requirements](https://github.com/leanprover/mathlib/blob/master/docs/contribute/doc.md) * [x] make sure definitions and lemmas are put in the right files * [x] make sure definitions and lemmas are not redundant If this PR is related to a discussion on Zulip, please include a link in the discussion. For reviewers: [code review check list](https://github.com/leanprover/mathlib/blob/master/docs/contribute/code-review.md)
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…munity#2152) Lemmas I found useful in my [combinatorics](https://b-mehta.github.io/combinatorics/) project Make sure you have: * [x] reviewed and applied the coding style: [coding](https://github.com/leanprover/mathlib/blob/master/docs/contribute/style.md), [naming](https://github.com/leanprover/mathlib/blob/master/docs/contribute/naming.md) * [x] reviewed and applied [the documentation requirements](https://github.com/leanprover/mathlib/blob/master/docs/contribute/doc.md) * [x] make sure definitions and lemmas are put in the right files * [x] make sure definitions and lemmas are not redundant If this PR is related to a discussion on Zulip, please include a link in the discussion. For reviewers: [code review check list](https://github.com/leanprover/mathlib/blob/master/docs/contribute/code-review.md)
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…munity#2152) Lemmas I found useful in my [combinatorics](https://b-mehta.github.io/combinatorics/) project Make sure you have: * [x] reviewed and applied the coding style: [coding](https://github.com/leanprover/mathlib/blob/master/docs/contribute/style.md), [naming](https://github.com/leanprover/mathlib/blob/master/docs/contribute/naming.md) * [x] reviewed and applied [the documentation requirements](https://github.com/leanprover/mathlib/blob/master/docs/contribute/doc.md) * [x] make sure definitions and lemmas are put in the right files * [x] make sure definitions and lemmas are not redundant If this PR is related to a discussion on Zulip, please include a link in the discussion. For reviewers: [code review check list](https://github.com/leanprover/mathlib/blob/master/docs/contribute/code-review.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lemmas I found useful in my combinatorics project
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list