Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/fintype): generalise to_finset_card #2316

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - chore(data/fintype): generalise to_finset_card #2316

wants to merge 14 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Apr 2, 2020 •
edited

Slight generalisation of a lemma, allowing a more flexible fintype instance.

Also americanises some spelling. :-)

@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 2, 2020
jcommelin
jcommelin reviewed Apr 2, 2020
View reviewed changes
src/data/fintype/fiber.lean Outdated Show resolved Hide resolved
src/data/fintype/fiber.lean Outdated Show resolved Hide resolved
src/data/fintype/fiber.lean Outdated Show resolved Hide resolved
@urkud
Copy link
Member

urkud commented Apr 3, 2020

Why do you define it for finite types only? Quite a few properties (I mean the fact that fibers are equivalence classes of (bot : setoid β).comap f) hold for any types, and for sets in fintype you can use fintype.card s for card-related properties.

@semorrison
Copy link
Collaborator Author

The main purpose of this work was to give me the fiber as a finset, because in the application in the hedetniemi branch we wanted a finset, and we needed to know various things about the finset we had produced. But I see your point, @urkud; this might be putting the glue in the wrong places.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 6, 2020
@semorrison semorrison changed the title feat(data/fintype): the fiber over a point (blocked on #2315) feat(data/fintype): the fiber over a point Apr 6, 2020
@semorrison
Copy link
Collaborator Author

Okay, @urkud is completely right that it's silly to do this valued in finset, so I've gutted it.

This PR now contains:

  1. americanisation of some spelling
  2. a tiny generalisation to to_finset_card which I found useful elsewhere

@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 9, 2020
@semorrison semorrison changed the title feat(data/fintype): the fiber over a point chore(data/fintype): generalise to_finset_card Jun 9, 2020
jcommelin
jcommelin approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 9, 2020
bors bot pushed a commit that referenced this pull request Jun 9, 2020
@semorrison
chore(data/fintype): generalise to_finset_card (#2316)
2845069 
Slight generalisation of a lemma, allowing a more flexible `fintype` instance.

Also americanises some spelling. :-)

Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bryangingechen
Copy link
Collaborator

The sensitivity proof needs to be updated: https://github.com/leanprover-community/mathlib/pull/2316/checks?check_run_id=753840867#step:5:84

bors r-

@bors
Copy link

bors bot commented Jun 9, 2020

Canceled.

@bryangingechen bryangingechen removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 9, 2020
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Jun 10, 2020
jcommelin
jcommelin reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 10, 2020
bors bot pushed a commit that referenced this pull request Jun 10, 2020
@semorrison
chore(data/fintype): generalise to_finset_card (#2316)
6a0412e 
Slight generalisation of a lemma, allowing a more flexible `fintype` instance.

Also americanises some spelling. :-)

Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jun 10, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/fintype): generalise to_finset_card [Merged by Bors] - chore(data/fintype): generalise to_finset_card Jun 10, 2020
@bors bors bot closed this Jun 10, 2020
@bors bors bot deleted the fiber branch June 10, 2020 08:49
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@semorrison @cipher1024
chore(data/fintype): generalise to_finset_card (leanprover-communit…
b98f081 
…y#2316)

Slight generalisation of a lemma, allowing a more flexible `fintype` instance.

Also americanises some spelling. :-)

Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwbarton rwbarton rwbarton left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@semorrison @urkud @bryangingechen @rwbarton @jcommelin