Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/algebra): more on restrict_scalars #2445

Closed
wants to merge 26 commits into from
Closed

[Merged by Bors] - feat(ring_theory/algebra): more on restrict_scalars #2445

wants to merge 26 commits into from

Conversation

semorrison
Copy link
Collaborator

No description provided.

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Apr 18, 2020
sgouezel
sgouezel reviewed Apr 18, 2020
View reviewed changes
src/ring_theory/algebra.lean Outdated Show resolved Hide resolved
src/ring_theory/algebra.lean Outdated Show resolved Hide resolved
src/ring_theory/algebra.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 18, 2020
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 18, 2020
@semorrison semorrison changed the title feat(ring_theory/algebra): more on restrict_scalars feat(ring_theory/algebra): more on restrict_scalars (blocked on #2444) Apr 18, 2020
@sgouezel
Copy link
Collaborator

Could you merge master to help us see what is new in this PR?

@semorrison
Copy link
Collaborator Author

Okay, I've just merged master.

@semorrison semorrison changed the title feat(ring_theory/algebra): more on restrict_scalars (blocked on #2444) feat(ring_theory/algebra): more on restrict_scalars Apr 19, 2020
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 19, 2020
jcommelin
jcommelin reviewed Apr 20, 2020
View reviewed changes
src/ring_theory/algebra.lean Outdated Show resolved Hide resolved
src/ring_theory/algebra.lean Outdated Show resolved Hide resolved
@semorrison semorrison added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Apr 23, 2020
@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 22, 2020
sgouezel
sgouezel reviewed May 23, 2020
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have played with it in an application and checked that this API is working, I am fully convinced. Could you fix the two minor issues pointed out by Johan and myself, before merging it?

bord d+

src/ring_theory/algebra.lean Show resolved Hide resolved
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 24, 2020
@semorrison
Copy link
Collaborator Author

bors merge

@bors
Copy link

bors bot commented May 26, 2020

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 26, 2020
@semorrison semorrison removed the awaiting-author A reviewer has asked the author a question or requested changes label May 26, 2020
@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request May 26, 2020
@semorrison
feat(ring_theory/algebra): more on restrict_scalars (#2445)
f6347a8 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 26, 2020

Build failed:

@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request May 26, 2020
@semorrison
feat(ring_theory/algebra): more on restrict_scalars (#2445)
f01e09c 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 26, 2020

Build failed:

@jcommelin
Copy link
Member

please bors please 🥺

bors merge

bors bot pushed a commit that referenced this pull request May 26, 2020
@semorrison
feat(ring_theory/algebra): more on restrict_scalars (#2445)
b4d4d9a 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 26, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/algebra): more on restrict_scalars [Merged by Bors] - feat(ring_theory/algebra): more on restrict_scalars May 26, 2020
@bors bors bot closed this May 26, 2020
@bors bors bot deleted the restrict_scalars branch May 26, 2020 10:39
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@semorrison @cipher1024
feat(ring_theory/algebra): more on restrict_scalars (leanprover-commu…
0aa0632 
…nity#2445)

Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@sgouezel sgouezel sgouezel left review comments

Assignees

@semorrison semorrison

Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @sgouezel @jcommelin @bryangingechen