Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(category_theory/limits): remove an unnecessary axiom in has_image_map #2455

Closed
wants to merge 1 commit into from

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Apr 19, 2020

I somehow missed the fact that has_image_map.factor_map is actually a consequence of has_image_map.map_ι together with the fact that image.ι is always a monomorphism.

TO CONTRIBUTORS:

Please include a summary of the changes made in this PR above "TO CONTRIBUTORS:", as that text will become the commit message. You are also encouraged to append the following co-authorship template if you'd like to acknowledge suggestions / commits made by other users:

Co-authored-by: name name@example.com

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • reviewed and applied the documentation requirements
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

If you're confused by comments on your PR like bors r+ or bors d+, please see our notes on bors for information on our merging workflow.

@TwoFX TwoFX added the awaiting-review The author would like community review of the PR label Apr 19, 2020
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 19, 2020
bors bot pushed a commit that referenced this pull request Apr 19, 2020
…_map (#2455)

I somehow missed the fact that `has_image_map.factor_map` is actually a consequence of `has_image_map.map_ι` together with the fact that `image.ι` is always a monomorphism.
@bors
Copy link

bors bot commented Apr 19, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(category_theory/limits): remove an unnecessary axiom in has_image_map [Merged by Bors] - fix(category_theory/limits): remove an unnecessary axiom in has_image_map Apr 19, 2020
@bors bors bot closed this Apr 19, 2020
@bors bors bot deleted the image-fix branch April 19, 2020 16:22
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…_map (leanprover-community#2455)

I somehow missed the fact that `has_image_map.factor_map` is actually a consequence of `has_image_map.map_ι` together with the fact that `image.ι` is always a monomorphism.
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…_map (leanprover-community#2455)

I somehow missed the fact that `has_image_map.factor_map` is actually a consequence of `has_image_map.map_ι` together with the fact that `image.ι` is always a monomorphism.
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…_map (leanprover-community#2455)

I somehow missed the fact that `has_image_map.factor_map` is actually a consequence of `has_image_map.map_ι` together with the fact that `image.ι` is always a monomorphism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants