-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(category_theory): wide pullbacks and limits in the over category #2461
Conversation
Regarding how to document the /-- The left point of the walking cospan. -/
abbreviation walking_cospan.left : walking_cospan := some walking_pair.left |
Do you think you could add some larger scale documentation, in the module doc-strings in these files, explaining the motivation for introducing wide pullbacks in the first place:
|
I mentioned this linter warning on zulip here: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Linter.20rejects.20automatic.20instance - not sure how to fix this. |
Okay, I think I'm happy with this. Do you want to add the dual statements to this PR? |
bors merge |
…#2461) This PR introduces [wide pullbacks](https://ncatlab.org/nlab/show/wide+pullback). Ordinary pullbacks are then defined as a special case of wide pullbacks, which simplifies some of the definitions and proofs there. Finally we show that the existence of wide pullbacks in `C` gives products in the slice `C/B`, and in fact gives all limits. Co-authored-by: Keeley Hoek <keeley@hoek.io>
Pull request successfully merged into master. Build succeeded: |
…leanprover-community#2461) This PR introduces [wide pullbacks](https://ncatlab.org/nlab/show/wide+pullback). Ordinary pullbacks are then defined as a special case of wide pullbacks, which simplifies some of the definitions and proofs there. Finally we show that the existence of wide pullbacks in `C` gives products in the slice `C/B`, and in fact gives all limits. Co-authored-by: Keeley Hoek <keeley@hoek.io>
…leanprover-community#2461) This PR introduces [wide pullbacks](https://ncatlab.org/nlab/show/wide+pullback). Ordinary pullbacks are then defined as a special case of wide pullbacks, which simplifies some of the definitions and proofs there. Finally we show that the existence of wide pullbacks in `C` gives products in the slice `C/B`, and in fact gives all limits. Co-authored-by: Keeley Hoek <keeley@hoek.io>
…leanprover-community#2461) This PR introduces [wide pullbacks](https://ncatlab.org/nlab/show/wide+pullback). Ordinary pullbacks are then defined as a special case of wide pullbacks, which simplifies some of the definitions and proofs there. Finally we show that the existence of wide pullbacks in `C` gives products in the slice `C/B`, and in fact gives all limits. Co-authored-by: Keeley Hoek <keeley@hoek.io>
This PR introduces wide pullbacks.
Ordinary pullbacks are then defined as a special case of wide pullbacks, which simplifies some of the definitions and proofs there.
Finally we show that the existence of wide pullbacks in
C
gives products in the sliceC/B
, and in fact gives all limits.TO CONTRIBUTORS:
This PR may break some downstream code using pullbacks, but only slightly (as can be seen in pullbacks.lean). In particular, the only thing that used to work that doesn't any more would be applying cases to a
walking_cospan
- but thanks to the super helpfulpullback_cone.is_limit.mk
andpullback_cone.equalizer_ext
, one shouldn't need to take cases on awalking_cospan
anyway.I haven't done the dual construction - of course before this PR is merged it should probably be included.
The new proof would of course follow by not changing the definition of pullback the same and showing an equivalence of categories between
wide_pullback_shape walking_pair
andwalking_cospan
, but since the change does simplify some proofs I've kept it for now.The docs linter complains about
and I'd appreciate suggestions of what sort of docs would be helpful here.
Make sure you have:
For reviewers: code review check list
If you're confused by comments on your PR like
bors r+
orbors d+
, please see our notes on bors for information on our merging workflow.