[Merged by Bors] - chore(*): only import one file per line #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This already works in Lean 3.9: import tactic.localized
open_locale classical |
|
Nevertheless, I'm a fan of this idea. |
sgouezel
reviewed
Apr 20, 2020
|
Okay, that's hopefully it. |
Good suggestion. I've done this now. |
semorrison
added
the
awaiting-review
jcommelin
approved these changes
Apr 21, 2020
sgouezel
reviewed
Apr 21, 2020
|
You can merge this once the conflicts are fixed. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 22, 2020
This perhaps-unnecessarily-obsessive PR puts every import statement on its own line. Why? 1. it's nice to be able to grep for `import X` 2. ~~if we enforced this, it would be easier deal with commands after imports, etc.~~ (irrelevant in 3.9) 3. it means I can remove all unnecessary transitive imports with a script 4. it's just tidier. :-) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
This perhaps-unnecessarily-obsessive PR puts every import statement on its own line. Why? 1. it's nice to be able to grep for `import X` 2. ~~if we enforced this, it would be easier deal with commands after imports, etc.~~ (irrelevant in 3.9) 3. it means I can remove all unnecessary transitive imports with a script 4. it's just tidier. :-) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
This perhaps-unnecessarily-obsessive PR puts every import statement on its own line. Why? 1. it's nice to be able to grep for `import X` 2. ~~if we enforced this, it would be easier deal with commands after imports, etc.~~ (irrelevant in 3.9) 3. it means I can remove all unnecessary transitive imports with a script 4. it's just tidier. :-) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
This perhaps-unnecessarily-obsessive PR puts every import statement on its own line. Why? 1. it's nice to be able to grep for `import X` 2. ~~if we enforced this, it would be easier deal with commands after imports, etc.~~ (irrelevant in 3.9) 3. it means I can remove all unnecessary transitive imports with a script 4. it's just tidier. :-) Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This perhaps-unnecessarily-obsessive PR puts every import statement on its own line.
Why?
import Xif we enforced this, it would be easier deal with commands after imports, etc.(irrelevant in 3.9)