Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(*): small additions that prepare for Chevalley-Warning #2560

Closed
wants to merge 2 commits into from

Conversation

jcommelin
Copy link
Member

A number a small changes that prepare for #1564.

TO CONTRIBUTORS:

Please include a summary of the changes made in this PR above "TO CONTRIBUTORS:", as that text will become the commit message. You are also encouraged to append the following co-authorship template if you'd like to acknowledge suggestions / commits made by other users:

Co-authored-by: name name@example.com

Make sure you have:

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

If you're confused by comments on your PR like bors r+ or bors d+, please see our notes on bors for information on our merging workflow.

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Apr 29, 2020
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 30, 2020
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 30, 2020
@urkud
Copy link
Member

urkud commented Apr 30, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 30, 2020
bors bot pushed a commit that referenced this pull request Apr 30, 2020
@bors
Copy link

bors bot commented Apr 30, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 30, 2020
@bors
Copy link

bors bot commented Apr 30, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(*): small additions that prepare for Chevalley-Warning [Merged by Bors] - feat(*): small additions that prepare for Chevalley-Warning Apr 30, 2020
@bors bors bot closed this Apr 30, 2020
@bors bors bot deleted the chev-warn-pre1 branch April 30, 2020 21:10
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants