Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(analysis/complex/exponential): split into three files in special_functions/ #2565

Closed
wants to merge 7 commits into from

Conversation

sgouezel
Copy link
Collaborator

@sgouezel sgouezel commented Apr 29, 2020

The file analysis/complex/exponential.lean was growing out of control (2500 lines) and was dealing with complex and real exponentials, trigonometric functions, and power functions. I split it into three files corresponding to these three topics, and put them instead in analysis/special_functions/, as it was not specifically complex.

This is purely a refactor, so absolutely no new material nor changed proof.

Related Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.232565.20exponential.20split

@sgouezel sgouezel added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 29, 2020
@sgouezel sgouezel added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 29, 2020
@sgouezel sgouezel changed the title refactor(analysis/complex/exponential): split into three files, blocked by #2564 refactor(analysis/complex/exponential): split into three files in special_functions/ Apr 29, 2020
@jcommelin
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 30, 2020
bors bot pushed a commit that referenced this pull request Apr 30, 2020
…cial_functions/ (#2565)

The file `analysis/complex/exponential.lean` was growing out of control (2500 lines) and was dealing with complex and real exponentials, trigonometric functions, and power functions. I split it into three files corresponding to these three topics, and put them instead in `analysis/special_functions/`, as it was not specifically complex.

This is purely a refactor, so absolutely no new material nor changed proof.

Related Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.232565.20exponential.20split
@bors
Copy link

bors bot commented Apr 30, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(analysis/complex/exponential): split into three files in special_functions/ [Merged by Bors] - refactor(analysis/complex/exponential): split into three files in special_functions/ Apr 30, 2020
@bors bors bot closed this Apr 30, 2020
@bors bors bot deleted the sgouezel_exponential branch April 30, 2020 08:18
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…cial_functions/ (leanprover-community#2565)

The file `analysis/complex/exponential.lean` was growing out of control (2500 lines) and was dealing with complex and real exponentials, trigonometric functions, and power functions. I split it into three files corresponding to these three topics, and put them instead in `analysis/special_functions/`, as it was not specifically complex.

This is purely a refactor, so absolutely no new material nor changed proof.

Related Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.232565.20exponential.20split
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…cial_functions/ (leanprover-community#2565)

The file `analysis/complex/exponential.lean` was growing out of control (2500 lines) and was dealing with complex and real exponentials, trigonometric functions, and power functions. I split it into three files corresponding to these three topics, and put them instead in `analysis/special_functions/`, as it was not specifically complex.

This is purely a refactor, so absolutely no new material nor changed proof.

Related Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.232565.20exponential.20split
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…cial_functions/ (leanprover-community#2565)

The file `analysis/complex/exponential.lean` was growing out of control (2500 lines) and was dealing with complex and real exponentials, trigonometric functions, and power functions. I split it into three files corresponding to these three topics, and put them instead in `analysis/special_functions/`, as it was not specifically complex.

This is purely a refactor, so absolutely no new material nor changed proof.

Related Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.232565.20exponential.20split
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants