[Merged by Bors] - fix(tactic/lint/basic): remove default argument for auto_decl and enable more linters #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgouezel
reviewed
May 1, 2020
| @@ -55,10 +55,10 @@ begin | |||
| { assume h, subst h, exact forall₂_refl _ } | |||
| end | |||
|
|
|||
| @[simp] lemma forall₂_nil_left_iff {l} : forall₂ r nil l ↔ l = nil := | |||
| @[simp, priority 900] lemma forall₂_nil_left_iff {l} : forall₂ r nil l ↔ l = nil := | |||
There was a problem hiding this comment.
Because they overlap with another simp lemma:
mathlib/src/data/list/defs.lean
Line 279 in 67f3fde
The forall₂.nil lemma is a constructor, and therefore the linter did not catch this issue before.
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 1, 2020
…ble more linters (#2580) Run more linters on automatically-generated declarations. Quite a few linters should have been run on them, but I forgot about it because the `auto_decls` flag is optional and off by default. I've made it non-optional so that you don't forget about it when defining a linter. https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/simp.20linter.20and.20structure.20fields/near/195810856
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
jcommelin
pushed a commit
that referenced
this pull request
May 1, 2020
…ble more linters (#2580) Run more linters on automatically-generated declarations. Quite a few linters should have been run on them, but I forgot about it because the `auto_decls` flag is optional and off by default. I've made it non-optional so that you don't forget about it when defining a linter. https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/simp.20linter.20and.20structure.20fields/near/195810856
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…ble more linters (leanprover-community#2580) Run more linters on automatically-generated declarations. Quite a few linters should have been run on them, but I forgot about it because the `auto_decls` flag is optional and off by default. I've made it non-optional so that you don't forget about it when defining a linter. https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/simp.20linter.20and.20structure.20fields/near/195810856
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…ble more linters (leanprover-community#2580) Run more linters on automatically-generated declarations. Quite a few linters should have been run on them, but I forgot about it because the `auto_decls` flag is optional and off by default. I've made it non-optional so that you don't forget about it when defining a linter. https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/simp.20linter.20and.20structure.20fields/near/195810856
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…ble more linters (leanprover-community#2580) Run more linters on automatically-generated declarations. Quite a few linters should have been run on them, but I forgot about it because the `auto_decls` flag is optional and off by default. I've made it non-optional so that you don't forget about it when defining a linter. https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/simp.20linter.20and.20structure.20fields/near/195810856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run more linters on automatically-generated declarations. Quite a few linters should have been run on them, but I forgot about it because the
auto_declsflag is optional and off by default. I've made it non-optional so that you don't forget about it when defining a linter.https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/simp.20linter.20and.20structure.20fields/near/195810856