Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/integral_domain): sum in integral domain indexed by finite group #2623

Closed
wants to merge 19 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented May 7, 2020

In other words: nontrivial sums are trivial

Moved from field_theory.finite to the new ring_theory.integral_domain:

  • card_nth_roots_subgroup_units
  • subgroup_units_cyclic

@jcommelin jcommelin changed the title feat(ring_theory/integral_domain): a sum in an integral domain indexed by finite group is zero feat(ring_theory/integral_domain): sum in integral domain indexed by finite group May 8, 2020
@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label May 10, 2020
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 12, 2020
bors bot pushed a commit that referenced this pull request May 12, 2020
…finite group (#2623)

In other words: nontrivial sums are trivial

Moved from `field_theory.finite` to the new `ring_theory.integral_domain`:
- `card_nth_roots_subgroup_units`
- `subgroup_units_cyclic`

Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented May 12, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/integral_domain): sum in integral domain indexed by finite group [Merged by Bors] - feat(ring_theory/integral_domain): sum in integral domain indexed by finite group May 12, 2020
@bors bors bot closed this May 12, 2020
@bors bors bot deleted the sum_units_subgroup branch May 12, 2020 09:24
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…finite group (leanprover-community#2623)

In other words: nontrivial sums are trivial

Moved from `field_theory.finite` to the new `ring_theory.integral_domain`:
- `card_nth_roots_subgroup_units`
- `subgroup_units_cyclic`

Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…finite group (leanprover-community#2623)

In other words: nontrivial sums are trivial

Moved from `field_theory.finite` to the new `ring_theory.integral_domain`:
- `card_nth_roots_subgroup_units`
- `subgroup_units_cyclic`

Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
bors bot pushed a commit that referenced this pull request May 17, 2020
This PR adds some preparations for the Chevalley–Warning theorem.

depends on: ~#2606, #2607, #2623~
bors bot pushed a commit that referenced this pull request May 17, 2020
This PR adds some preparations for the Chevalley–Warning theorem.

depends on: ~#2606, #2607, #2623~
bors bot pushed a commit that referenced this pull request May 17, 2020
This PR adds some preparations for the Chevalley–Warning theorem.

depends on: ~#2606, #2607, #2623~

Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…finite group (leanprover-community#2623)

In other words: nontrivial sums are trivial

Moved from `field_theory.finite` to the new `ring_theory.integral_domain`:
- `card_nth_roots_subgroup_units`
- `subgroup_units_cyclic`

Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…r-community#2590)

This PR adds some preparations for the Chevalley–Warning theorem.

depends on: ~leanprover-community#2606, leanprover-community#2607, leanprover-community#2623~

Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants