Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/ring): lemmas about units in a semiring #2680

Closed
wants to merge 18 commits into from

Conversation

101damnations
Copy link
Collaborator

@101damnations 101damnations commented May 14, 2020

The lemmas in non-localization files from #2675. (Apart from one, which wasn't relevant to #2675).

(Edit: I am bad at git. I was hoping there would only be 1 commit here. I hope whatever I'm doing wrong is inconsequential...)

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉. Don't worry about git. We've got little bots that will take care (-;

src/algebra/ring.lean Outdated Show resolved Hide resolved
src/algebra/ring.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 14, 2020
@101damnations
Copy link
Collaborator Author

101damnations commented May 14, 2020

oh no oh no I forgot to #lint and the linter doesn't like the first two simps - hope bors doesn't mind if I add a commit

edit: sorry bors
edit edit: I've just found the zulip thread explaining that bors does mind this. Sorry that someone's gonna have to reapprove :(

@bors
Copy link

bors bot commented May 14, 2020

Canceled.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels May 14, 2020
@ChrisHughes24
Copy link
Member

bors merge

@bors
Copy link

bors bot commented May 14, 2020

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 14, 2020
@ChrisHughes24 ChrisHughes24 removed the awaiting-author A reviewer has asked the author a question or requested changes label May 14, 2020
@bryangingechen
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request May 14, 2020
The lemmas in non-localization files from #2675. (Apart from one, which wasn't relevant to #2675).

(Edit: I am bad at git. I was hoping there would only be 1 commit here. I hope whatever I'm doing wrong is inconsequential...)
@bors
Copy link

bors bot commented May 14, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/ring): lemmas about units in a semiring [Merged by Bors] - chore(algebra/ring): lemmas about units in a semiring May 14, 2020
@bors bors bot closed this May 14, 2020
@bors bors bot deleted the units_lemmas branch May 14, 2020 18:21
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 15, 2020
…munity#2680)

The lemmas in non-localization files from leanprover-community#2675. (Apart from one, which wasn't relevant to leanprover-community#2675).

(Edit: I am bad at git. I was hoping there would only be 1 commit here. I hope whatever I'm doing wrong is inconsequential...)
anrddh pushed a commit to anrddh/mathlib that referenced this pull request May 16, 2020
…munity#2680)

The lemmas in non-localization files from leanprover-community#2675. (Apart from one, which wasn't relevant to leanprover-community#2675).

(Edit: I am bad at git. I was hoping there would only be 1 commit here. I hope whatever I'm doing wrong is inconsequential...)
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…munity#2680)

The lemmas in non-localization files from leanprover-community#2675. (Apart from one, which wasn't relevant to leanprover-community#2675).

(Edit: I am bad at git. I was hoping there would only be 1 commit here. I hope whatever I'm doing wrong is inconsequential...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants