[Merged by Bors] - perf(tactic/ring): use new norm_num, avoid mk_app #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This halves the compile time of |
gebner
reviewed
May 15, 2020
src/tactic/ring.lean
Outdated
| meta inductive horner_expr : Type | ||
| | const (e : expr) : horner_expr | ||
| | const (e : expr × ℚ) : horner_expr |
There was a problem hiding this comment.
Suggested change
| | const (e : expr × ℚ) : horner_expr | |
| | const (e : expr) (coeff : ℚ) : horner_expr |
Having a product as argument to a constructor feels really odd.
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 15, 2020
Remove `tactic.norm_num` from `ring`, and do some performance upgrades borrowed from the `norm_num` overhaul while I'm at it. Co-authored-by: Johan Commelin <johan@commelin.net>
github-actions
bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…ty#2685) Remove `tactic.norm_num` from `ring`, and do some performance upgrades borrowed from the `norm_num` overhaul while I'm at it. Co-authored-by: Johan Commelin <johan@commelin.net>
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 16, 2020
…ty#2685) Remove `tactic.norm_num` from `ring`, and do some performance upgrades borrowed from the `norm_num` overhaul while I'm at it. Co-authored-by: Johan Commelin <johan@commelin.net>
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…ty#2685) Remove `tactic.norm_num` from `ring`, and do some performance upgrades borrowed from the `norm_num` overhaul while I'm at it. Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
tactic.norm_numfromring, and do some performance upgrades borrowed from thenorm_numoverhaul while I'm at it.