Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory): Product comparison #2753

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(category_theory): Product comparison #2753

wants to merge 5 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented May 20, 2020 •
edited by jcommelin

Construct the product comparison morphism, and show it's an iso iff F preserves binary products.

@b-mehta b-mehta added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label May 20, 2020
@b-mehta b-mehta force-pushed the product-comparison branch 2 times, most recently from 2de5718 to a5cd54a Compare May 20, 2020 17:11
@b-mehta
Copy link
Collaborator Author

b-mehta commented May 20, 2020

Sorry for force-pushes!

@b-mehta b-mehta added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels May 20, 2020
@semorrison
Copy link
Collaborator

Could you add a sentence about these results in the module doc strings of both files?

@semorrison
Copy link
Collaborator

Also, linter complains about missing doc strings.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 22, 2020
@b-mehta b-mehta added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 22, 2020
@jcommelin
Copy link
Member

The linter is still complaining.

@b-mehta b-mehta requested a review from semorrison May 23, 2020 13:20
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 24, 2020
bors bot pushed a commit that referenced this pull request May 24, 2020
@b-mehta
feat(category_theory): Product comparison (#2753)
8590081 
Construct the product comparison morphism, and show it's an iso iff F preserves binary products.
@bors
Copy link

bors bot commented May 24, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory): Product comparison [Merged by Bors] - feat(category_theory): Product comparison May 24, 2020
@bors bors bot closed this May 24, 2020
@bors bors bot deleted the product-comparison branch May 24, 2020 17:03
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@b-mehta @cipher1024
feat(category_theory): Product comparison (leanprover-community#2753)
f441329 
Construct the product comparison morphism, and show it's an iso iff F preserves binary products.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison Awaiting requested review from semorrison

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@b-mehta @semorrison @jcommelin