Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(src/algebra/ordered_ring.lean): fix linting errors #2827

Conversation

Vierkantor
Copy link
Collaborator

Mentioned, but not really discussed, in this Zulip thread.

This PR also removes mul_pos' and mul_nonneg' lemmas because they are now identical to the improved mul_pos and mul_nonneg.

Also get rid of `mul_pos'` and `mul_nonneg'` lemmas because they are now
identical to the improved `mul_pos` and `mul_nonneg`.
@Vierkantor Vierkantor added the awaiting-review The author would like community review of the PR label May 26, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request May 26, 2020
[Mentioned, but not really discussed, in this Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/How.20to.20get.20familiar.20enough.20with.20Mathlib.20to.20use.20it/near/198747067).

This PR also removes `mul_pos'` and `mul_nonneg'` lemmas because they are now identical to the improved `mul_pos` and `mul_nonneg`.
@bors
Copy link

bors bot commented May 26, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(src/algebra/ordered_ring.lean): fix linting errors [Merged by Bors] - chore(src/algebra/ordered_ring.lean): fix linting errors May 26, 2020
@bors bors bot closed this May 26, 2020
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…community#2827)

[Mentioned, but not really discussed, in this Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/How.20to.20get.20familiar.20enough.20with.20Mathlib.20to.20use.20it/near/198747067).

This PR also removes `mul_pos'` and `mul_nonneg'` lemmas because they are now identical to the improved `mul_pos` and `mul_nonneg`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants