[Merged by Bors] - chore(algebra): displace zero_ne_one_class with nonzero and make no_zero_divisors a Prop #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
May 28, 2020
Co-authored-by: Johan Commelin <johan@commelin.net>
jcommelin
reviewed
May 28, 2020
kckennylau
changed the title
kckennylau
added
the
awaiting-review
ChrisHughes24
approved these changes
May 29, 2020
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 29, 2020
…ero_divisors a Prop (#2847) - `[nonzero_semiring α]` becomes `[semiring α] [nonzero α]` - `[nonzero_comm_semiring α]` becomes `[comm_semiring α] [nonzero α]` - `[nonzero_comm_ring α]` becomes `[comm_ring α] [nonzero α]` - `no_zero_divisors` is now a `Prop` - `units.ne_zero` (originally for `domain`) merges into `units.coe_ne_zero` (originally for `nonzero_comm_semiring`)
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…ero_divisors a Prop (leanprover-community#2847) - `[nonzero_semiring α]` becomes `[semiring α] [nonzero α]` - `[nonzero_comm_semiring α]` becomes `[comm_semiring α] [nonzero α]` - `[nonzero_comm_ring α]` becomes `[comm_ring α] [nonzero α]` - `no_zero_divisors` is now a `Prop` - `units.ne_zero` (originally for `domain`) merges into `units.coe_ne_zero` (originally for `nonzero_comm_semiring`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[nonzero_semiring α]becomes[semiring α] [nonzero α][nonzero_comm_semiring α]becomes[comm_semiring α] [nonzero α][nonzero_comm_ring α]becomes[comm_ring α] [nonzero α]no_zero_divisorsis now aPropunits.ne_zero(originally fordomain) merges intounits.coe_ne_zero(originally fornonzero_comm_semiring)