[Merged by Bors] - feat(order): countable categoricity of dense linear orders #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwarn
added
the
blocked-by-other-PR
b-mehta
reviewed
May 31, 2020
bryangingechen
added
awaiting-author
|
@dwarn is this still WIP? |
|
@robertylewis Sorry, I haven't done any Lean these past few months and sort of abandoned this PR. I had a look just now to bring it up to date with current mathlib and also add a stub about order embeddings. This will prove for example that any countable ordinal embeds in the reals. There's still a bit of work required to make this mergeable (move some lemmas as Bhavik suggested, finish construction of order embedding, naming, doc strings, ...). |
|
@dwarn Okay, great! In that case we'll leave the PR open and tagged as it is. Whenever you're ready, please change the label to "awaiting review." |
dwarn
added
awaiting-review
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Vierkantor
reviewed
Nov 3, 2020
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Thank you 🎉 bors r+ |
github-actions
bot
added
ready-to-merge
|
Thanks to all reviewers! |
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2020
We construct an order isomorphism between any two countable, nonempty, dense linear orders without endpoints, using the back-and-forth method.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We construct an order isomorphism between any two countable, nonempty, dense linear orders without endpoints, using the back-and-forth method.
Blocked by #2850