New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(linear_algebra/affine_space): use implicit args #2905
Conversation
I think this is fine. Affine spaces and torsors do often need explicit type arguments (when a definition only has points as explicit arguments, it seems Lean can't figure out the types of vectors and scalars; when it only has points and vectors as explicit arguments, it seems Lean can't figure out the type of scalars, for example), but this case doesn't need those explicit arguments (and there may be other definitions that are also taking more explicit type arguments than necessary). |
I'm making more args implicit. Should be ready soon. |
Also rename `.add` to `map_vadd'`.
comp
@urkud I'm still trying to get a feel for the new superpowers that coercion to function now has. Should |
@jcommelin I think that this kind of a refactor should be done simultaneously for all bundled homs. |
Ok, that's a fair point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Whenever we have an argument `f : affine_map k V P`, Lean can figure out `k`, `V`, and `P`.
Pull request successfully merged into master. Build succeeded: |
…munity#2905) Whenever we have an argument `f : affine_map k V P`, Lean can figure out `k`, `V`, and `P`.
Whenever we have an argument
f : affine_map k V P
, Lean can figure outk
,V
, andP
.