Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/add_torsor): add equiv.const_vadd and equiv.vadd_const #2907

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(algebra/add_torsor): add equiv.const_vadd and equiv.vadd_const #2907

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 1, 2020

Also define their isometric.* versions in analysis/normed_space/add_torsor.

@urkud
feat(algebra/add_torsor): add equiv.const_vadd and equiv.vadd_const
5e14387 
Also define their `isometric.*` versions in `analysis/normed_space/add_torsor`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 2, 2020
@urkud urkud requested a review from jsm28 June 2, 2020 15:42
jsm28
jsm28 reviewed Jun 2, 2020
View reviewed changes
Copy link
Collaborator

@jsm28 jsm28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I should note that I don't know the conventions for when a lemma should be left_cancel versus cancel_left (both being in use in mathlib).

@urkud
Copy link
Member Author

urkud commented Jun 2, 2020

left_cancel vs cancel_left

I didn't notice this. I'll change my lemmas to match the rest of the file. We can fix *_cancel vs cancel_* in the whole library in another PR.

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 2, 2020
@urkud
Copy link
Member Author

urkud commented Jun 5, 2020

It seems that left_cancel is mostly used for lemmas like a * b = a * c → b = c and cancel_left for lemmas like (a + b) - (a + c) = b - c. Adjusted the names.

@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 5, 2020
@urkud urkud requested a review from jcommelin June 5, 2020 04:58
jcommelin
jcommelin approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 5, 2020
bors bot pushed a commit that referenced this pull request Jun 5, 2020
@urkud
feat(algebra/add_torsor): add equiv.const_vadd and `equiv.vadd_cons…
edb4422 
…t` (#2907)

Also define their `isometric.*` versions in `analysis/normed_space/add_torsor`.
@bors
Copy link

bors bot commented Jun 5, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/add_torsor): add equiv.const_vadd and equiv.vadd_const [Merged by Bors] - feat(algebra/add_torsor): add equiv.const_vadd and equiv.vadd_const Jun 5, 2020
@bors bors bot closed this Jun 5, 2020
@bors bors bot deleted the const-vadd branch June 5, 2020 10:00
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@urkud @cipher1024
feat(algebra/add_torsor): add equiv.const_vadd and `equiv.vadd_cons…
2faf5aa 
…t` (leanprover-community#2907)

Also define their `isometric.*` versions in `analysis/normed_space/add_torsor`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@jsm28 jsm28 jsm28 left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @jsm28