[Merged by Bors] - feat(ring/localization): add fraction map for int to rat cast #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Jun 2, 2020
jcommelin
added
the
awaiting-author
bryangingechen
changed the title
Co-authored-by: Johan Commelin <johan@commelin.net>
alexjbest
force-pushed
the
cast-rat-fraction-map
branch
from
c999162
to
a3e21a7
Compare
|
Hi, apologies for the delay (and force push), I think I've addressed your comments now, thanks! |
jcommelin
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Thanks 🎉
(@alexjbest I've slightly reformatted the proofs, I hope you don't mind.)
bors merge
|
👎 Rejected by label |
github-actions
bot
added
the
ready-to-merge
bryangingechen
removed
the
awaiting-author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 8, 2020
Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…over-community#2921) Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.