[Merged by Bors] - chore(algebra/group_with_zero_power): review #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a copy of `fpow_neg_one` with a misleading name.
urkud
changed the title
fpow_inv
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 6, 2020
List of changes: * Rename `gpow_neg_succ` to `gpow_neg_succ_of_nat` to match other names in `int` namespace. * Add `units.coe_gpow`. * Remove `fpow_neg_succ`, leave `fpow_neg_succ_of_nat`. * Rewrite the proof of `fpow_add` in the same way I rewrote the proof of `gpow_add`. * Make argument `a` implicit in some lemmas because they have an argument `ha : a ≠ 0`. * Remove `fpow_inv`. This was a copy of `fpow_neg_one` with a misleading name. * Remove `unit_pow` in favor of a more general `units.coe_pow`. * Remove `unit_gpow`, add a more general `units.coe_gpow'` instead.
|
bors r- |
urkud
removed
the
ready-to-merge
|
Build fails, so I removed this from the queue. |
github-actions
bot
added
the
ready-to-merge
|
bors merge |
|
Already running a review |
bors bot
pushed a commit
that referenced
this pull request
Jun 6, 2020
List of changes: * Rename `gpow_neg_succ` to `gpow_neg_succ_of_nat` to match other names in `int` namespace. * Add `units.coe_gpow`. * Remove `fpow_neg_succ`, leave `fpow_neg_succ_of_nat`. * Rewrite the proof of `fpow_add` in the same way I rewrote the proof of `gpow_add`. * Make argument `a` implicit in some lemmas because they have an argument `ha : a ≠ 0`. * Remove `fpow_inv`. This was a copy of `fpow_neg_one` with a misleading name. * Remove `unit_pow` in favor of a more general `units.coe_pow`. * Remove `unit_gpow`, add a more general `units.coe_gpow'` instead.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
List of changes: * Rename `gpow_neg_succ` to `gpow_neg_succ_of_nat` to match other names in `int` namespace. * Add `units.coe_gpow`. * Remove `fpow_neg_succ`, leave `fpow_neg_succ_of_nat`. * Rewrite the proof of `fpow_add` in the same way I rewrote the proof of `gpow_add`. * Make argument `a` implicit in some lemmas because they have an argument `ha : a ≠ 0`. * Remove `fpow_inv`. This was a copy of `fpow_neg_one` with a misleading name. * Remove `unit_pow` in favor of a more general `units.coe_pow`. * Remove `unit_gpow`, add a more general `units.coe_gpow'` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
gpow_neg_succtogpow_neg_succ_of_natto match other names inintnamespace.units.coe_gpow.fpow_neg_succ, leavefpow_neg_succ_of_nat.fpow_addin the same way I rewrote the proof ofgpow_add.aimplicit in some lemmas because they have an argumentha : a ≠ 0.fpow_inv. This was a copy offpow_neg_onewith a misleading name.unit_powin favor of a more generalunits.coe_pow.unit_gpow, add a more generalunits.coe_gpow'instead.