Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(dynamics/circle): define translation number of a lift of a circle homeo #2974

Closed
wants to merge 8 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 7, 2020

Define a structure circle_deg1_lift, a function translation_number : circle_deg1_lift → ℝ, and prove some basic properties


Has merge conflicts with #2973

@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 7, 2020
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super nice and neat. I just have very minor comments.

src/dynamics/circle/rotation_number/basic.lean Outdated Show resolved Hide resolved
src/dynamics/circle/rotation_number/basic.lean Outdated Show resolved Hide resolved
src/dynamics/circle/rotation_number/basic.lean Outdated Show resolved Hide resolved
src/dynamics/circle/rotation_number/basic.lean Outdated Show resolved Hide resolved
src/dynamics/circle/rotation_number/basic.lean Outdated Show resolved Hide resolved
src/dynamics/circle/rotation_number/basic.lean Outdated Show resolved Hide resolved
src/dynamics/circle/rotation_number/basic.lean Outdated Show resolved Hide resolved
src/dynamics/circle/rotation_number/basic.lean Outdated Show resolved Hide resolved
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@sgouezel
Copy link
Collaborator

sgouezel commented Jun 8, 2020

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 8, 2020
bors bot pushed a commit that referenced this pull request Jun 8, 2020
…e homeo (#2974)

Define a structure `circle_deg1_lift`, a function `translation_number : circle_deg1_lift → ℝ`, and prove some basic properties
@bors
Copy link

bors bot commented Jun 8, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(dynamics/circle): define translation number of a lift of a circle homeo [Merged by Bors] - feat(dynamics/circle): define translation number of a lift of a circle homeo Jun 8, 2020
@bors bors bot closed this Jun 8, 2020
@bors bors bot deleted the rotnum branch June 8, 2020 07:55
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…e homeo (leanprover-community#2974)

Define a structure `circle_deg1_lift`, a function `translation_number : circle_deg1_lift → ℝ`, and prove some basic properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants