[Merged by Bors] - chore(data/matrix/basic): clean up of new lemmas on matrix numerals #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These should have been review comments on @pechersky's recent #2987 PR, but I was too slow. |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 9, 2020
…2996) Generalise and improve use of `@[simp]` for some newly added lemmas about matrix numerals. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
semorrison
added
awaiting-review
|
@semorrison Why is the section pulled outside of diagonal? The |
|
I guess that was an oversight on my part when defining the lemmas in #2987. |
|
@pechersky It sounds like you might need to open another PR, so I've sent you an invitation to collaborate on mathlib so you can create branches in this repo; that'll make it easier for us to see the build status of each commit. |
semorrison
removed
the
awaiting-review
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…eanprover-community#2996) Generalise and improve use of `@[simp]` for some newly added lemmas about matrix numerals. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalise and improve use of
@[simp]for some newly added lemmas about matrix numerals.