[Merged by Bors] - feat(linear_algebra/finite_dimensional): bases given by finsets #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, it might be more straightforward working with finsets of the vector space instead of indexed types or carrying around a proof of set.finite. Also provide a lemma on equal dimension and basis cardinality lemma that uses a finset basis.
bryangingechen
added
the
awaiting-review
Like in `findim_eq_card_basis`, the fin-dim-ness of K V is not necessary for the proof. The instance requirement is removed, and the docstring is made to be similar to the docstring for `findim_eq_card_basis`, highlighting the use of `finset`.
semorrison
reviewed
Jun 13, 2020
semorrison
reviewed
Jun 13, 2020
semorrison
added
awaiting-author
pechersky
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 16, 2020
In some cases, it might be more straightforward working with finsets of the vector space instead of indexed types or carrying around a proof of set.finite. Also provide a lemma on equal dimension and basis cardinality lemma that uses a finset basis. Co-authored-by: Scott Morrison scott.morrison@gmail.com
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…prover-community#3041) In some cases, it might be more straightforward working with finsets of the vector space instead of indexed types or carrying around a proof of set.finite. Also provide a lemma on equal dimension and basis cardinality lemma that uses a finset basis. Co-authored-by: Scott Morrison scott.morrison@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it might be more straightforward working with finsets of
the vector space instead of indexed types or carrying around a proof of
set.finite. Also provide a lemma on equal dimension
and basis cardinality lemma that uses a finset basis.
Co-authored-by: Scott Morrison scott.morrison@gmail.com
Developed based on discussion in
https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/working.20with.20finset.20and.20fintype