[Merged by Bors] - refactor(topology/uniform_space): docstring and notation #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
changed the title
|
@PatrickMassot I changed the PR title. Feel free to change it again. |
|
I hopefully fixed build. I forgot I modified one statement to a defeq one, but it seems this is not equal enough for some later proof. I also noticed I forgot the |
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
|
Thank you very much Rob and Bryan for translating my docstrings into English. I'm sorry I should probably have caught some of these. |
bryangingechen
added
the
awaiting-review
bryangingechen
approved these changes
Jun 13, 2020
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 13, 2020
The goal of this PR is to make `topology/uniform_space/basic.lean` more accessible. First it introduces the standard notation for relation composition that was inexplicably not used before. I used a non-standard unicode circle here `\ciw` but this is up for discussion as long as it looks like a composition circle. Then I introduced balls as discussed on [this Zulip topic](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/notations.20for.20uniform.20spaces). There could be used more, but at least this should be mostly sufficient for following PRs. And of course I put a huge module docstring. As with `order/filter/basic.lean`, I think we need more mathematical explanations than in the average mathlib file. I also added a bit of content about symmetric entourages but I don't have enough courage to split this off unless someone really insists.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…community#3052) The goal of this PR is to make `topology/uniform_space/basic.lean` more accessible. First it introduces the standard notation for relation composition that was inexplicably not used before. I used a non-standard unicode circle here `\ciw` but this is up for discussion as long as it looks like a composition circle. Then I introduced balls as discussed on [this Zulip topic](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/notations.20for.20uniform.20spaces). There could be used more, but at least this should be mostly sufficient for following PRs. And of course I put a huge module docstring. As with `order/filter/basic.lean`, I think we need more mathematical explanations than in the average mathlib file. I also added a bit of content about symmetric entourages but I don't have enough courage to split this off unless someone really insists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make
topology/uniform_space/basic.leanmore accessible.First it introduces the standard notation for relation composition that was inexplicably not used before. I used a non-standard unicode circle here
\ciwbut this is up for discussion as long as it looks like a composition circle.Then I introduced balls as discussed on this Zulip topic. There could be used more, but at least this should be mostly sufficient for following PRs.
And of course I put a huge module docstring. As with
order/filter/basic.lean, I think we need more mathematical explanations than in the average mathlib file.I also added a bit of content about symmetric entourages but I don't have enough courage to split this off unless someone really insists.