Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra): elements of a dim zero space #3054

Closed
wants to merge 7 commits into from

Conversation

robertylewis
Copy link
Member


I haven't touched linear algebra in a while; this came up in #3021 so I gave it a shot. A few related but unused lemmas also.

@robertylewis robertylewis added the awaiting-review The author would like community review of the PR label Jun 12, 2020
@@ -412,6 +412,14 @@ by rw [rank, rank, linear_map.range_comp]; exact dim_map_le _ _

end rank

lemma eq_zero_of_dim_zero (h : vector_space.dim K V = 0) (x : V) : x = 0 :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also have the iff variation: dimension is zero iff every vector is zero. Otherwise this looks good to me (and not having these lemmas when you need them is certainly annoying).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrmacbeth has (the contrapositive of) that in #3021. To be honest I'm not really sure which statement would be the most useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iff version is nice and clean; why don't you do that, and I'll adjust my PR accordingly?

Copy link
Member

@hrmacbeth hrmacbeth Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And one other variant: the contrapositive of your current statement is (∃ b : V, b ≠ 0) → (vector_space.dim K V ≠ 0), but for convenience maybe it would be nice to have a version with the conclusion vector_space.dim K V > 0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've made it into an iff. And with a little update to push_neg (cc @PatrickMassot), I have the useful contrapositive version as well, subsuming the version in #3021.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, the push_neg change wasn't actually needed.

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 13, 2020
bors bot pushed a commit that referenced this pull request Jun 13, 2020
Co-authored-by: Rob Lewis <rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Jun 13, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra): elements of a dim zero space [Merged by Bors] - feat(linear_algebra): elements of a dim zero space Jun 13, 2020
@bors bors bot closed this Jun 13, 2020
@bors bors bot deleted the la-empty-space branch June 13, 2020 08:06
hrmacbeth added a commit that referenced this pull request Jun 13, 2020
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants