Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/finset): rename ext/ext'/ext_iff #3069

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - chore(data/finset): rename ext/ext'/ext_iff #3069

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 14, 2020 •
edited

Now

  • ext is the @[ext] lemma;
  • ext_iff is the lemma s₁ = s₂ ↔ ∀ a, a ∈ s₁ ↔ a ∈ s₂.

Also add 2 norm_cast attributes and a lemma ssubset_iff_of_subset.

@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 14, 2020
@semorrison
Copy link
Collaborator

Looks great!

We should codify this naming pattern in https://leanprover-community.github.io/contribute/naming.html.

bryangingechen
bryangingechen approved these changes Jun 14, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge if it builds.

src/number_theory/quadratic_reciprocity.lean Outdated Show resolved Hide resolved
@semorrison
Copy link
Collaborator

I recorded the naming advice at leanprover-community/leanprover-community.github.io#60.

@urkud
Copy link
Member Author

urkud commented Jun 14, 2020

Built locally
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 14, 2020
bors bot pushed a commit that referenced this pull request Jun 14, 2020
@urkud
chore(data/finset): rename ext/ext'/ext_iff (#3069)
0d05299 
Now

* `ext` is the `@[ext]` lemma;
* `ext_iff` is the lemma `s₁ = s₂ ↔ ∀ a, a ∈ s₁ ↔ a ∈ s₂`.

Also add 2 `norm_cast` attributes and a lemma `ssubset_iff_of_subset`.
@bors
Copy link

bors bot commented Jun 14, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/finset): rename ext/ext'/ext_iff [Merged by Bors] - chore(data/finset): rename ext/ext'/ext_iff Jun 14, 2020
@bors bors bot closed this Jun 14, 2020
@bors bors bot deleted the finset-ext branch June 14, 2020 17:56
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@urkud @cipher1024
chore(data/finset): rename ext/ext'/ext_iff (leanprover-communi…
2f82aa1 
…ty#3069)

Now

* `ext` is the `@[ext]` lemma;
* `ext_iff` is the lemma `s₁ = s₂ ↔ ∀ a, a ∈ s₁ ↔ a ∈ s₂`.

Also add 2 `norm_cast` attributes and a lemma `ssubset_iff_of_subset`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @semorrison @bryangingechen