Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linear_algebra/quotient_module): avoid using type class inference for setoids #310

Merged
merged 4 commits into from
Sep 5, 2018

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Sep 3, 2018

Continuation of #212 . Avoid using type class inference for quotient modules, and introduce a version of quotient.mk specifically for quotient modules, whose output type is quotient β s rather than quotient (quotient_rel s), which should help type class inference
TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

@johoelzl johoelzl merged commit 97cd01b into leanprover-community:master Sep 5, 2018
@ChrisHughes24 ChrisHughes24 deleted the quotient_module branch September 13, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants