Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/uniform_space): some basic lemmas #3123

Closed
wants to merge 3 commits into from

Conversation

PatrickMassot
Copy link
Member

This is the second PR on the road to Heine. It contains various elementary lemmas about uniform spaces.


This PR is slightly controversial. You won't notice if you only look at the diff, but some of those lemmas are almost duplicating existing lemmas. This is because I'm returning to Bourbaki instead of following Johannes. The main differences are Johannes loves filter.lift' and he doesn't like symmetric entourages. So some lemmas from this PR are expressed without lift' but have the same mathematical content as existing lemmas using lift' and some lemmas from this PR are symmetric versions of existing lemmas.

@bryangingechen bryangingechen added the awaiting-review The author would like community review of the PR label Jun 21, 2020
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind having lemmas using symmetric uniformities. I just have two minor comments.

bors d+

@@ -461,6 +502,25 @@ lemma ball_eq_of_symmetry {V : set (β × β)} (hV : symmetric_rel V) {x} :
ball x V = {y | (y, x) ∈ V} :=
by { ext y, rw mem_ball_symmetry hV, exact iff.rfl }

lemma mem_comp_of_mem_ball {V W : set (β × β)} {x y z : β} (hV : symmetric_rel V)
(hx : x ∈ ball z V) (hy : y ∈ ball z W) : (x, y) ∈ V ○ W :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(hx : x ∈ ball z V) (hy : y ∈ ball z W) : (x, y) ∈ V ○ W :=
(hx : x ∈ ball z V) (hy : y ∈ ball z W) : (x, y) ∈ V ○ W :=

exact mem_sets_of_superset r_in r_sub, }
end

lemma uniformity_has_basis_closure : has_basis (𝓤 α) (λ V : set (α × α), V ∈ 𝓤 α) closure :=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A docstring on this one would be welcome, as the has_basis ... closure is surprising at first, before one tries to remember what has_basis really says.

@bors
Copy link

bors bot commented Jun 21, 2020

✌️ PatrickMassot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@PatrickMassot
Copy link
Member Author

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 21, 2020
bors bot pushed a commit that referenced this pull request Jun 21, 2020
This is the second PR on the road to Heine. It contains various elementary lemmas about uniform spaces.
@bors
Copy link

bors bot commented Jun 21, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/uniform_space): some basic lemmas [Merged by Bors] - feat(topology/uniform_space): some basic lemmas Jun 21, 2020
@bors bors bot closed this Jun 21, 2020
@bors bors bot deleted the heine-2 branch June 21, 2020 19:44
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…#3123)

This is the second PR on the road to Heine. It contains various elementary lemmas about uniform spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants