Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/ordered_group): merge add_le_add' with add_le_add #3159

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 24, 2020

Also drop mul_le_mul'' (was a weaker version of mul_le_mul').


I used sed to replace add_le_add' with add_le_add. Waiting for CI.

Also drop `mul_le_mul''` (was a weaker version of `mul_le_mul'`).
@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 24, 2020
@robertylewis
Copy link
Member

It looks like you just had to remove the ' with no other changes, right? Why did all these variants exist in the first place?

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 24, 2020
bors bot pushed a commit that referenced this pull request Jun 24, 2020
…3159)

Also drop `mul_le_mul''` (was a weaker version of `mul_le_mul'`).
@urkud
Copy link
Member Author

urkud commented Jun 24, 2020

Some of these lemmas used to be in the core.

@bors
Copy link

bors bot commented Jun 24, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/ordered_group): merge add_le_add' with add_le_add [Merged by Bors] - chore(algebra/ordered_group): merge add_le_add' with add_le_add Jun 24, 2020
@bors bors bot closed this Jun 24, 2020
@bors bors bot deleted the add-le-add branch June 24, 2020 20:50
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…eanprover-community#3159)

Also drop `mul_le_mul''` (was a weaker version of `mul_le_mul'`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants