Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(measure_theory/outer_measure,measure_space): use complete_lattice_of_Inf/Sup #3185

Closed
wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 26, 2020

Also add a few supporting lemmas about bsupr/binfi to order/complete_lattice


…ice_of_Inf/Sup`

Also add a few supporting lemmas about `bsupr`/`binfi` to `order/complete_lattice`
@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 26, 2020
@sgouezel
Copy link
Collaborator

LGTM, but CI failed. Can you restart it?

@bryangingechen
Copy link
Collaborator

I've just restarted it. For future reference (in case it happens again), in the previous run, the leanchecker step in "Run tests and docs" timed out.

@bryangingechen
Copy link
Collaborator

Ugh, looks like github actions is having troubles again. Let's try restarting it a bit later...

@urkud
Copy link
Member Author

urkud commented Jun 26, 2020

I tried to run leanchecker locally, and it starts eating lots of memory after 2-3 minutes. But I can't understand which change causes this. @gebner ?

@fpvandoorn
Copy link
Member

Looks good!

  • Could you add a comment about the naming convention of bsupr (ideally in a module doc at the top of complete_lattice). This name is not used widely yet.
  • There is a single other bsupr that seems to have a different meaning in the file complete_lattice. Could you rename that?

@fpvandoorn
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jun 26, 2020

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added the help-wanted The author needs attention to resolve issues label Jun 27, 2020
@bryangingechen
Copy link
Collaborator

@urkud urkud removed the help-wanted The author needs attention to resolve issues label Jun 28, 2020
@urkud
Copy link
Member Author

urkud commented Jun 28, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 28, 2020
bors bot pushed a commit that referenced this pull request Jun 28, 2020
…ice_of_Inf/Sup` (#3185)

Also add a few supporting lemmas about `bsupr`/`binfi` to `order/complete_lattice`
@bors
Copy link

bors bot commented Jun 28, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(measure_theory/outer_measure,measure_space): use complete_lattice_of_Inf/Sup [Merged by Bors] - chore(measure_theory/outer_measure,measure_space): use complete_lattice_of_Inf/Sup Jun 28, 2020
@bors bors bot closed this Jun 28, 2020
@bors bors bot deleted the measure-lattice branch June 28, 2020 22:28
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…ice_of_Inf/Sup` (leanprover-community#3185)

Also add a few supporting lemmas about `bsupr`/`binfi` to `order/complete_lattice`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants