Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory/limits): limit of point iso #3188

Closed
wants to merge 6 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Jun 26, 2020

Prove a cone is a limit given that the canonical morphism from it to a limiting cone is an iso.

@b-mehta b-mehta requested a review from semorrison June 26, 2020 19:12
@semorrison
Copy link
Collaborator

Looks good to me. Could you add the dual statement?

@semorrison semorrison added the awaiting-author A reviewer has asked the author a question or requested changes label Jun 26, 2020
Comment on lines 394 to 395
If the canonical morphism from a cone point to a limiting cone point is an iso, then the
first cone was limiting also.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update comment.

@semorrison
Copy link
Collaborator

The dual statement needs its doc-string updated. After that, good to go.

bors d+

@bors
Copy link

bors bot commented Jun 26, 2020

✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison
Copy link
Collaborator

bors merge

@bors
Copy link

bors bot commented Jun 27, 2020

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 27, 2020
@semorrison semorrison removed the awaiting-author A reviewer has asked the author a question or requested changes label Jun 27, 2020
@semorrison
Copy link
Collaborator

bors merge

bors bot pushed a commit that referenced this pull request Jun 27, 2020
Prove a cone is a limit given that the canonical morphism from it to a limiting cone is an iso.
@bors
Copy link

bors bot commented Jun 27, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits): limit of point iso [Merged by Bors] - feat(category_theory/limits): limit of point iso Jun 27, 2020
@bors bors bot closed this Jun 27, 2020
@bors bors bot deleted the limit-of-point-iso branch June 27, 2020 03:21
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…y#3188)

Prove a cone is a limit given that the canonical morphism from it to a limiting cone is an iso.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants