Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/valuation): definition and basic properties of valuations #3222

Closed
wants to merge 3 commits into from

Conversation

jcommelin
Copy link
Member

From the perfectoid project.


@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jun 29, 2020
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good!

I made a bunch of suggestions, feel free to ignore any you disagree with.

src/ring_theory/valuation/basic.lean Outdated Show resolved Hide resolved
src/ring_theory/valuation/basic.lean Outdated Show resolved Hide resolved
src/ring_theory/valuation/basic.lean Outdated Show resolved Hide resolved
src/ring_theory/valuation/basic.lean Outdated Show resolved Hide resolved
src/ring_theory/valuation/basic.lean Outdated Show resolved Hide resolved
src/ring_theory/valuation/basic.lean Outdated Show resolved Hide resolved
src/ring_theory/valuation/basic.lean Outdated Show resolved Hide resolved
@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 1, 2020
jcommelin and others added 2 commits July 1, 2020 08:04
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 1, 2020
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 1, 2020
bors bot pushed a commit that referenced this pull request Jul 1, 2020
@bors
Copy link

bors bot commented Jul 1, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/valuation): definition and basic properties of valuations [Merged by Bors] - feat(ring_theory/valuation): definition and basic properties of valuations Jul 1, 2020
@bors bors bot closed this Jul 1, 2020
@bors bors bot deleted the valuation-basic branch July 1, 2020 09:03
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants