[Merged by Bors] - feat(ring_theory/polynomial/homogeneous): definition and basic props #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also move ring_theory/polynomial.lean to ring_theory/polynomial/basic.lean This PR is part of bringing symmetric polynomials to mathlib, and besided that, I also expect to add binomial polynomials and Chebyshev polynomials in the future. Altogether, this motivates the starting of a ring_theory/polynomial directory. The file basic.lean may need cleaning or splitting at some point.
jcommelin
added
the
awaiting-review
semorrison
reviewed
Jun 30, 2020
semorrison
reviewed
Jun 30, 2020
semorrison
added
awaiting-author
Vierkantor
added a commit
that referenced
this pull request
Jun 30, 2020
…_theory.polynomial.basic` This PR is the intersection of #3223 and #3241, allowing them to be merged in either order. Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/where.20should.20these.20definitions.20live.3F
bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2020
…_theory.polynomial.basic` (#3248) This PR is the intersection of #3223 and #3241, allowing them to be merged in either order. Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/where.20should.20these.20definitions.20live.3F Co-authored-by: Johan Commelin <johan@commelin.net>
jcommelin
commented
Jun 30, 2020
jcommelin
added
awaiting-review
robertylewis
added
awaiting-author
jcommelin
added
awaiting-review
semorrison
reviewed
Aug 15, 2020
| import data.mv_polynomial | ||
| import data.fintype.card | ||
| import tactic | ||
| #print tactic.interactive.squeeze_simp |
There was a problem hiding this comment.
Suggested change
| #print tactic.interactive.squeeze_simp |
There was a problem hiding this comment.
Why did this pass CI? @bryangingechen @robertylewis
I remember putting this #print statement here exactly because I wanted CI to remind me that I should minimize imports... but apparently that trick doesn't work.
There was a problem hiding this comment.
CI doesn't check for a lack of #print statements. If you want a warning, #check a declaration that doesn't exist.
There was a problem hiding this comment.
Ooh, I thought it would complain about printing output...
There was a problem hiding this comment.
It should be possible to set it up to do that. I can't work on it right now, but please make an issue if you think it's a feature worth having and I'll try to come back to it when I can.
semorrison
reviewed
Aug 15, 2020
|
LGTM otherwise. bors d+ |
|
✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
No idea why the docs build failed, but I see this is on an old Lean, so I'm gonna merge master. |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Aug 16, 2020
…3223) This PR also move ring_theory/polynomial.lean to ring_theory/polynomial/basic.lean This PR is part of bringing symmetric polynomials to mathlib, and besided that, I also expect to add binomial polynomials and Chebyshev polynomials in the future. Altogether, this motivates the starting of a ring_theory/polynomial directory. The file basic.lean may need cleaning or splitting at some point. Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…_theory.polynomial.basic` (leanprover-community#3248) This PR is the intersection of leanprover-community#3223 and leanprover-community#3241, allowing them to be merged in either order. Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/where.20should.20these.20definitions.20live.3F Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also move ring_theory/polynomial.lean to
ring_theory/polynomial/basic.lean
This PR is part of bringing symmetric polynomials to mathlib,
and besided that, I also expect to add binomial polynomials
and Chebyshev polynomials in the future.
Altogether, this motivates the starting of a ring_theory/polynomial
directory.
The file basic.lean may need cleaning or splitting at some point.