Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(algebra/ring): move some classes to group_with_zero #3232

Closed
wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 29, 2020

Move nonzero, mul_zero_class and no_zero_divisors to
group_with_zero: these classes don't need (+).


Move `nonzero`, `mul_zero_class` and `no_zero_divisors` to
`group_with_zero`: these classes don't need `(+)`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 29, 2020
@urkud urkud requested a review from jcommelin June 29, 2020 22:34
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 30, 2020
bors bot pushed a commit that referenced this pull request Jun 30, 2020
Move `nonzero`, `mul_zero_class` and `no_zero_divisors` to
`group_with_zero`: these classes don't need `(+)`.
@bors
Copy link

bors bot commented Jun 30, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/ring): move some classes to group_with_zero [Merged by Bors] - chore(algebra/ring): move some classes to group_with_zero Jun 30, 2020
@bors bors bot closed this Jun 30, 2020
@bors bors bot deleted the gwz branch June 30, 2020 06:44
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…ver-community#3232)

Move `nonzero`, `mul_zero_class` and `no_zero_divisors` to
`group_with_zero`: these classes don't need `(+)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants